Open
Conversation
oliverb123
force-pushed
the
sig/component-inbox
branch
from
61b6b1e to
0bc6948
Compare
oliverb123
force-pushed
the
sig/component-inbox
branch
from
0bc6948 to
15b8317
Compare
Twixes
approved these changes
Apr 7, 2026
Member
Twixes
left a comment
Twixes
left a comment
There was a problem hiding this comment.
LGTM, just one file-naming note. Will ask Cursor to fix here
Member
There was a problem hiding this comment.
This should actually be named something like source-product-icons, as PascalCase means a component (or components) being exported - here, this is more like a consts file
PascalCase file names are reserved for files exporting React components. This file only exports constants, so use kebab-case instead. Co-authored-by: Michael Matloka <dev@twixes.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quoth the claude:
Also adds task UUID to the task view, because I needed it.